vunit icon indicating copy to clipboard operation
vunit copied to clipboard

Fix some Vivado issues (SystemVerilog support, space in file name, environment variable)

Open oscargus opened this issue 3 years ago • 7 comments

Closes #686 Closes #796 Closes #811

Not sure where it can be tested. Didn't really find a test file for vivado.py?

The vivado module is not in the documentation? So not really clear where I should document the environment variable. (But I can improve the documentation for run_vivado.

oscargus avatar Nov 07 '22 11:11 oscargus

Yes, please do something about the documentation. vivado.py started out more as an example as we generally do not maintain tool integrations other than what's related to simulators and we generally do not document the examples that much. Since this is becoming more than just an example I suggest that it also gets some documentation.

LarsAsplund avatar Nov 07 '22 12:11 LarsAsplund

Now there is some sort of documentation for the functions in the module. Located at the bottom of the "Documentation" section (below "Examples").

oscargus avatar Nov 07 '22 14:11 oscargus

Sorry to bother you @LarsAsplund , but can you please see if anything else is required (or if you prefer the Vivado menu entry elsewhere).

oscargus avatar Dec 02 '22 14:12 oscargus

Sorry for letting this slip. Will try to find some time "soon" to complete it.

oscargus avatar Aug 31 '23 08:08 oscargus

Finally got around to this. Not sure this is exactly what you wanted, but at least a "Tool Integration" menu item and then Vivado shows up there. Not clear to me how the "dynamic menus" work and if this will be an entry there (or if that it a better solution).

oscargus avatar Sep 09 '23 12:09 oscargus

Hello, bump on this one @oscargus @LarsAsplund . Any chance this could get pulled into mainline? This is very useful for using with Verification IPs

SzymonHitachi avatar Oct 11 '23 17:10 SzymonHitachi

I'll see what I can do in terms of splitting it. It's been a while.

oscargus avatar Mar 12 '24 16:03 oscargus