Oscar Gustafsson
Oscar Gustafsson
Thanks! I'll try to add tests and documentation.
This still needs tests for PNG and JPG output, but I cannot really figure out a good way to generate it without adding dependencies... Will try to generate a minimal...
I'm now thinking that it may make sense to save the figures to file (one of my use cases is to capture GraphViz graphs which can be quite big, so...
OK, so now it writes files. Also, I added support for `_repr_mimebundle_` in a way transparent for the user. Some objects, like GraphViz graphs, only support this. But asking for...
The content of `_repr_mimebundle_` takes precedence if it contains the correct type. This makes sense to avoid generating the same content twice. Also: https://github.com/scikit-learn/scikit-learn/blob/86541f2b3bc8a96264e265cb810cf79858544340/sklearn/base.py#L636-L638 It is hard to say how...
Another issue, I realize from the tests, is that SVGs are not supported by LaTeX out of the box. Of course it is a bit expected, but I wonder if...
Thanks! That is what I started to do. The SVG problem leads to failed doc builds, so it would be nice to at least figure out a way to avoid...
Marking this as ready for review now. Anything else that should be tested?
Managed to get thumbnails etc working... (Edit: well, not me, but calling the right function and voilà.)
I've tried to make it work, but to no avail. My theory is that the svg2pdf converter is not working since the sg image is an `imgsgnode` and not an...