Oscar Gustafsson

Results 474 comments of Oscar Gustafsson

Rationals and floats are inherently different in SymPy. For example, consider `(2**54-1)/2**55` vs `Rational(2**54-1, 2**55)`.

Try something like: ``` python minterms = np.array([1, 2]) ``` to see the first problem and ``` python minterms = list(minterms) ``` for the second.

I guess it should be `if not len(minterms)` (means the same thing, but static linters doesn't really like the `== 0` approach). I'm wondering if you actually need to convert...

It is a SymPy-function: https://github.com/sympy/sympy/blob/0b809238408bd4baa57146ffc9f82eb1685d8fd8/sympy/utilities/iterables.py#L3026 (although I admittedly forgot about it).

This is the answer from the current master: ![image](https://user-images.githubusercontent.com/8114497/132736500-da15ac2f-aeba-4d60-80cc-996c7adc81d4.png)

If both x and y are real we get: ![image](https://user-images.githubusercontent.com/8114497/132737347-483c36d2-af38-4492-b121-3f9fb43c38c3.png)

Typing always helps! Some minor comments (I have no powers to approve or merge or whatever, but for what it is worth).

Now there is some sort of documentation for the functions in the module. Located at the bottom of the "Documentation" section (below "Examples").

Sorry to bother you @LarsAsplund , but can you please see if anything else is required (or if you prefer the Vivado menu entry elsewhere).