Oscar Gustafsson

Results 474 comments of Oscar Gustafsson

The purpose of squashing commits is to reduce the number of commits (currently 25) either to a single commit or to a few commits each with a well-defined purpose. Not...

Ah, Matplotlib has a special greeting message, e.g.: https://github.com/matplotlib/matplotlib/pull/22612#pullrequestreview-901033022

Here is the code for that: https://github.com/matplotlib/matplotlib/blob/main/.github/workflows/pr_welcome.yml

> the less likely someone will be to actually read it. That is why it makes sense to have a "Welcome message" with some of the stuff in it. I'd...

> don't be afraid to ping people more often, This is the problem. "people". Who are they? It is not like they randomly pick names out of the 50. >...

> As I mentioned, I get pinged all the time. I can't even read every comment I am pinged on. So it wouldn't be an improvement if you are pinged...

Should we also have something similar for SymPy when it comes to deprecation removals? If I understand NEP29 correctly, they also have some NumPy compatibility scheme.

Here is the list of things included in 3.9: https://docs.python.org/3/whatsnew/3.9.html I guess simpler dict unions and maybe the typing improvements can be interesting?

My main issue is somehow shown in #22212. Quite a lot of them are comments to ignore the typing. Which in combination with the types, `Tuple` etc, quite often being...

Maybe. I guess the dicts are small enough so that the faster lookup is maybe not an issue?