vunit
vunit copied to clipboard
Fix issues when trying to parameterize Verilog modules
This fixes #944 by trying to execute an original version (case-insensitive for VHDL compatibility) with the fall-back for use with Verilog and non-lower-case module names.
Hi, any chance for having someone look at this PR? We use VUnit in our company and for now we had to switch to my unofficial branch.
I think it maybe is better to either:
- Move the case-handling to
get_test_bench
- Do try-except on
get_test_bench
only and then only checkKeyError
.
@oscargus I modified it as you suggested.
Thanks! (I should probably have mentioned that I cannot approve or merge anything, but I think/hope that the suggested changes increases the chance of having it merged...)
Can you possibly contact someone who is in charge of such approvals? This issue is preventing us for use of official VUnit repo in our workflow what is suboptimal at least...
I can try to ping in @LarsAsplund and @kraigher . My impression is that they have been quite busy recently though. (There may be other people that have the correct powers as well.)
Any chance to have this fix merged any time soon?