vunit icon indicating copy to clipboard operation
vunit copied to clipboard

Fix issues when trying to parameterize Verilog modules

Open piotrva opened this issue 1 year ago • 7 comments

This fixes #944 by trying to execute an original version (case-insensitive for VHDL compatibility) with the fall-back for use with Verilog and non-lower-case module names.

piotrva avatar Jul 12 '23 11:07 piotrva

Hi, any chance for having someone look at this PR? We use VUnit in our company and for now we had to switch to my unofficial branch.

piotrva avatar Jul 28 '23 12:07 piotrva

I think it maybe is better to either:

  1. Move the case-handling to get_test_bench
  2. Do try-except on get_test_bench only and then only check KeyError.

oscargus avatar Sep 09 '23 12:09 oscargus

@oscargus I modified it as you suggested.

piotrva avatar Oct 05 '23 14:10 piotrva

Thanks! (I should probably have mentioned that I cannot approve or merge anything, but I think/hope that the suggested changes increases the chance of having it merged...)

oscargus avatar Oct 06 '23 13:10 oscargus

Can you possibly contact someone who is in charge of such approvals? This issue is preventing us for use of official VUnit repo in our workflow what is suboptimal at least...

piotrva avatar Oct 06 '23 13:10 piotrva

I can try to ping in @LarsAsplund and @kraigher . My impression is that they have been quite busy recently though. (There may be other people that have the correct powers as well.)

oscargus avatar Oct 06 '23 14:10 oscargus

Any chance to have this fix merged any time soon?

piotrva avatar Dec 25 '23 19:12 piotrva