Nicolás Venturo

Results 144 comments of Nicolás Venturo

An issue with matching at the end is that we'd be forcing users to input the entire revert reason, which is not a requirement today. A best effort approach to...

Our assertions use [chai-bn](https://github.com/OpenZeppelin/chai-bn), which works with [bn.js](https://github.com/indutny/bn.js), because that's the one that [web3 1.0 uses](https://web3js.readthedocs.io/en/v1.2.0/web3-utils.html#bn), and the type that truffle v5.0 returns. I'm not aware of current libraries/frameworks using...

@PaulRBerg I saw you mentioned you used `bignumber.js` as a direct dependency: is there a reason to not use `bn.js` (which is what web3js and truffle support)?

Ohh I missed the fact that we have a direct dependency. I think we can safely update it though.

The promise resolves to an error string: in order to get the receipt, we should use the `PromiEvent` event listeners (either `error` or `promise`). However, as is discussed in https://github.com/ethereum/web3.js/issues/2612...

This would be extremely useful, making interacting with arbitrary contracts _way_ easier. We shouldn't need more than the contract's ABI to pull this off. And if the source is verified...

We should instead switch to `@openzeppelin/test-helpers`.

Though at some point we'll want to look into this, it's not required for ManagedPool because the scaling factor is a 'whole' floating point number (it is just `10**decimals_diff` -...

Stopping by to _enthusiastically_ voice support for this feature: creating simple arrays is extremely un-ergonomic (see e.g.: https://github.com/balancer-labs/balancer-v2-monorepo/blob/9e7a59e2281c1c182f1c604458a1391c0dbe44df/pkg/vault/contracts/authorizer/TimelockAuthorizerMigrator.sol#L145). Is there an estimated timeline for this feature to be complete?