Nicolás Venturo
Nicolás Venturo
Small things to add: - add chainid to poolid - expose reentrancy guard status - store timestamp instead of blocknumber in pool balances - make `joinPool` and `exitPool` return the...
@brunoguerios I'm not sure I follow, are you suggesting the minted BPT be deposited as user balance in a join, and burnt from user balance during an exit?
>No - actually I'd like for the user to be able to choose if the BPT they get from a join transaction is kept as internal balance or if it's...
This was the patch change: https://github.com/balancer/balancer-v2-monorepo/pull/2205
Incidentally #2296 did not add tests for the protocol fee cache update, but it should have.
The artifacts are what is published by npm: we can't publish the entire build info as that'd be too much data (and the package should be somewhat lightweight). The artifacts...
(fwiw we did now about these things, the Certora review simply highlighted how hard they make it to understand the system). We also want some small features, such as a...
This was the patch change: https://github.com/balancer/balancer-v2-monorepo/pull/2206
Hello @xenide! You are correct in that the comments don't make sense given the current state of the code. I believe we wrote those a while ago, and later decided...
The reason why it's not a concern is that we added recovery mode, which completely bypasses any invariant calculations and simply performs a proportional withdrawal. That's (if I recall correctly)...