Nicolás Venturo

Results 144 comments of Nicolás Venturo

Have you performed any gas measurements to compare them? Also bytecode size differences.

#2032 added this for AaveLinear - we'll likely want to have this in `NewBasePool` and propagate it to all other pool types.

This was discused offline a bit. One concern is that `break` may trick developers to e.g. think they're getting a performance boost because they're immediately exiting a loop - which...

In that case I'd consider having a constrained `break` produce an error message with a link to some docs that explain why breaking in a circuit does not provide any...

I was unable - I tried replicating this by creating a second crate and calling a function declared there, but doing so I ended up triggering a different ICE: see...

>Would it make sense to do it at the variable level, but not try to detect constraining, but ask the dev to explicitly use let a_prime = a.has_been_constrained() and use...

For what it's worth, the above code [compiles in Rust](https://play.rust-lang.org/?version=stable&mode=debug&edition=2021&gist=76ce07ddc136cc9bc84bd0b7946d69b4) (with minor modifications: Rust requires that we use the type parameter _somewhere_ for `SomeType`, and also that we further constrain...

Something worth mentioning is that in the original aztec-nr scenario, this was triggered when I added a concrete implementation (in the same crate). I am not sure why this example...

>This is the expected error, your call_library_fn is generic over any type SomeType, so we don't know if this type implements Trait or not. You need to restrict this method...

Sure, created #4508 and #4509. I didn't want to spam you with random requests, but I'm happy to do things that way in the future!