Nicolás Venturo
Nicolás Venturo
I love everything about this
This is an interesting limitation of the Contracts library and Solidity in general. The behavior you want to change is encapsulated inside `EnumerableMap` (as can be seem by you fixing...
>Free functions would actually go against this idea. Because you'd need to have a concept of a group of internal functions? (what is now sort of achieved with `library`)
Thanks for pointing that out!
Superceded by https://github.com/balancer-labs/balancer-v2-monorepo/pull/1452
We could have a second prefix that marks read-only refs, and e.g. have something like the following: ``` function _getChainedReferenceValue(uint256 ref) internal override returns (uint256 value) { (bytes32 slot, bool...
We may want to wait until https://github.com/ethereum/solidity/issues/10698 is solved before migrating. See [this comment](https://github.com/OpenZeppelin/openzeppelin-contracts/pull/3431#issuecomment-1144104066) on how the lack of that feature negatively affects gas usage.
After reading the docs more carefully, I realized that the actual change 0.8 introduced is to make enums always have at most 256 elements, not make the type wider. So...
Hello @folex! Sorry we took so long to reply. It seems the readme is outdated, as it instructs to run all tests at once. We typically run tests on a...
https://github.com/balancer-labs/balancer-v2-monorepo/pull/1500 added some integration tests, but we should still have unit tests. The biggest hurdle is we need to set up the entire liq. mining program (veBAL, GaugeController, minter, etc.).