starter-kit-gsn icon indicating copy to clipboard operation
starter-kit-gsn copied to clipboard

./node_modules/web3-eth-accounts/src/scrypt.js Critical dependency: the request of a dependency is an expression

Open abcoathup opened this issue 6 years ago • 4 comments

Running the client npm start in the client directory gives the following warning:

Compiled with warnings.

./node_modules/web3-eth-accounts/src/scrypt.js
Critical dependency: the request of a dependency is an expression

Search for the keywords to learn more about each warning.
To ignore, add // eslint-disable-next-line to the line before.

Checking dependencies:

$ npm ls web3-eth-accounts
[email protected] /c/Users/andre/Documents/projects/forum/starter/client
└─┬ [email protected]
  └─┬ [email protected]
    └── [email protected]

The issue is apparently resolved in [email protected] according to: https://github.com/ethereum/web3.js/issues/3018

abcoathup avatar Dec 29 '19 21:12 abcoathup

@abcoathup Yes, this got already fixed and released but be aware to update your package-lock file :)

nivida avatar Jan 06 '20 09:01 nivida

This should be fixed with #35 and #36. @abcoathup can you check?

nventuro avatar Jan 14 '20 15:01 nventuro

@nventuro https://github.com/OpenZeppelin/starter-kit-gsn/blob/master/client/package.json uses [email protected] so it isn't fixed yet.

abcoathup avatar Jan 16 '20 04:01 abcoathup

Ohh I missed the fact that we have a direct dependency. I think we can safely update it though.

nventuro avatar Jan 16 '20 17:01 nventuro