Kris Nuttycombe comments

Results 229 comments of


                                            Kris Nuttycombe

Enable UTXOs spent in expired shielding transactions to be spendable

Between #1402, #1473 and #1496 we now believe this to be resolved.

zcash_client_backend: Create the framework for an in-memory wallet backend

Closing as completed by #1634, #1923,

`create_account` should raise an error if the caller attempts to create multiple accounts using different seeds.

We now allow having UFVKs corresponding to multiple distinct seeds to be stored in the wallet, so raising an error no longer makes sense.

`zcash_client_*`: Fix bug where transparent funds can't be shielded before the normal confirmation depth

I just successfully performed 1-conf shielding with Zashi 1.2.2 (which updates to the latest SDK release). So I'm closing this as fixed.

[ZIP-233] Network Sustainability Mechanism: Burning

@aphelionz there's an underlying clippy CI issue being fixed in https://github.com/zcash/librustzcash/pull/1785 - you might want to rebase once that merges to clear this issue.

[ZIP-233] Network Sustainability Mechanism: Burning

https://github.com/zcash/librustzcash/pull/1879 now builds atop this branch, merging `main` and addressing comments from review.

Do not return transparent balance associated with unified addresses from `getbalance`.

Converting back to draft because it's necessary to fix #5720 as a prerequisite to fixing `gettransaction` to only return legacy transaction information (`gettransaction` was also affected by the issue that...

`decrypt_diversifier` incorrectly returns `None`.

> For context, the address was taken from the outgoing sapling change note, decrypted with the OVK. The incoming sapling change note was also successfully decrypted with the internally scoped...

Support empty block range end in `getaddresstxids` calls.

Okay, yep, that looks like a zcashd bug. I can see how it's coming from the very weird implementation of https://github.com/zcash/zcash/blob/master/src/rpc/misc.cpp#L826-L852

Support empty block range end in `getaddresstxids` calls.

Let me consult with @daira and/or @str4d on what we need to do here.