Kris Nuttycombe
Kris Nuttycombe
Unresolved comment from #915: https://github.com/zcash/zips/pull/915/files#r1829961172
@LarryRuane the way to handle updating the protobuf files is just to do the following: ``` git subtree -P lightwallet-protocol/ pull [email protected]:zcash/lightwallet-protocol.git main --squash ``` I would create a temporary...
Hmmm, I am not sure here. I think the existing use of `vec` may actually be a bug, I just didn’t notice it because there there are no uses of...
I believe that the objectives of this PR were eventually satisfied by #1634
Note to be resolved during the editing period: https://github.com/zcash/zips/pull/913#discussion_r1828428953
We had identified a couple of bugs, one in `get_wallet_summary` and another in the wallet application, both of which were fixed, but we have not verified that the issue is...
Related to #1413
> I'm looking at #1570 (the proposed fix for #1411), and it seems like without the changes in that PR, `transparent::add_transparent_account_balances` does not take account of `min_confirmations` (as passed to...
@daira recently had a realization about the meaning of having different confirmation depths for change notes relative to confirmation depths for non-change notes related to the proposed scheme in ZIP...
> We should also take into account the fact that when checking balances, we often do want to use `min_confirmations = 0` for shielded pools (so that balance doesn't temporarily...