Kris Nuttycombe

Results 229 comments of Kris Nuttycombe

I believe that this has now been resolved by the combination of #1306 and #1402

After a brief look over the code, I think what's happening is that the change notes that were created under the old rules where the note was sent back to...

I have a more philosophical objection to the notion of fees being prescribed by consensus: this couples the miner's choice of network consensus rules that govern when transactions are considered...

The invariant of the `blocks` table is that an entry can only exist for a block that the wallet has scanned. The join to the `blocks` table is to ensure...

#1140, #1142 and #1143 are intended to produce this result: ```mermaid %%{init: {"flowchart": {"defaultRenderer": "elk"}} }%% graph TD subgraph standalone_components nEqH[equihash] nF4J[f4jumble] nZEnc[zcash_encoding] end subgraph protocol_components nZNE[zcash_note_encryption] nZip32[zip32] nZSpec[zcash_spec] end...

This is now in an acceptable state; we no longer have circular dependencies that result in cycles in the repository graph.