Kris Nuttycombe

Results 229 comments of Kris Nuttycombe

Okay, yeah, if you think you introduced this bug then fixing it would be helpful! :)

@daira This should be rebased now that rendering is done on the `publish` branch.

Instead of `OutPoint`, this method could take a sum type that is `OutPoint | SaplingNullifier | OrchardNullifier`. This API leaks the same amount of information to the `lightwalletd` server as...

@Oscar-Pepper You're misunderstanding it then. The `txid` component of an `OutPoint` returns the transaction in which an output was created. What we want is, given an `OutPoint`, determine the transaction...

From @str4d: * Design a wallet format that can sufficiently represent what we want to support in the new wallet. * Create a Rust API for adding data to that...

This will ideally be resolved by implementing the `lightwalletd` changes specified in https://github.com/zcash/lightwalletd/issues/498 and then using the transaction data requests system to fetch this data.

What we need here is a path for the wallet application to report failure to send back to the wallet.

There's a clippy lint that needs to be fixed (just a duplicate import); also, please check the intra-doc linking error. I have the fix locally, but since `nerdcash` is an...

Also it appears that there are some test failures that need to be resolved.

> I'll take a look. I ran `cargo test` at the root and that passed, but I'll see what the command line is to run tests that are failing. And...