Steve Myers comments

Results 580 comments of


                                            Steve Myers

add validate domain option to electrum

Take a look at the utils.rs file and on line 403 you need to use this new param you're adding.

Added validate_domain Electrum option

Hi, thanks for adding a `validate_domain` option, can you make it a flag instead of something that takes a true or false value? See here: https://docs.rs/clap/latest/clap/_derive/_tutorial/index.html#flags

High level write-up of what you can do with bdk-ffi

Chatted with @thunderbiscuit and would like to make this a feature matrix section in the web docs. Showing feature supported for: `bdk`, `bdk-cli`(?), `bdk-kotlin`, `bdk-swift`, `bdk-python`.

High level write-up of what you can do with bdk-ffi

FYI I did a high level write up for my [talk at BitDevsLA] this weekend. It might be useful info for this discussion on how to document BDK features. I...

Add current grantees section to foundation page

Looks like this one needs to be rebased. Plus how do you feel about grouping by quarter, so we just did our Q2 Full Time and Project grants. For full...

Test the bitcoin `v0.32.0-rc1` release

replaced by #1448

chore: add `print_stdout`/`print_stderr` lints to workspace level

This looks like the right way to prevent prints from getting into the code. But do we even want to allow them on tests? The only place I think they...

[chain] Change tx_last_seen to `Option<u64>`

@ValuedMammal if this is already rebased and ready to go please change the status to "ready to review".

Transaction Sorting and Querying

Need to confirm how this should be done with the new wallet API. I don't think the best way to do this will be via queries directly on the DB,...

Subscribe to script hashes when using electrum client

I moved this to the 1.1 milestone since it's not out of scope for 1.0 but could be done in a follow-on feature release without changing 1.0 BDK APIs.