bdk icon indicating copy to clipboard operation
bdk copied to clipboard

Test the bitcoin `v0.32.0-rc1` release

Open tcharding opened this issue 1 year ago • 4 comments

Please excuse the noise if this is not of interest to you guys right now. No action required from the bdk team - this is just informational and so the rust-bitcoin team can see that bitcoin rc1 release is ok.

Test the latest bitcoin release candidate. Includes an unreleased patched version of rust-miniscript (master branch + depend on bitcoin rc release).

Notes:

  • This wouldn't have been too hard if I knew my way around the codebase and didn't try to rush. The new miniscript::Threshold usage took me down a dark path for a while :)
  • Leaves a few calls to expect that require more invasive error handling improvements
  • Uses the ugly weight.to_wu() as usize instead of using the new Weight type more thoroughly
  • Uses network.into() liberally instead of using the new NetworkKind more thoroughly
  • The Sequence / RelLockTime stuff is a bit rough too

But I believe this proves the rc1 release is pretty good as it is.

cargo test --color=always --workspace --all-features --all-targets passes all tests on my machine.

tcharding avatar Apr 10 '24 03:04 tcharding

@tcharding Are you planning on continuing working on this PR towards merge ? I'm asking just to know if I should start working on another one (on top of this one) on behalf of #1422 :)

oleonardolima avatar May 06 '24 11:05 oleonardolima

I"d love it if you took over. Feel free to use any of my work, change it, or drop it as you see fit. No attribution needed.

FTR we need to get an updated version of rust-bitcoincore-rpc out as well as rust-miniscript before you guys can start using 0.32.0

tcharding avatar May 06 '24 23:05 tcharding

I"d love it if you took over. Feel free to use any of my work, change it, or drop it as you see fit. No attribution needed.

FTR we need to get an updated version of rust-bitcoincore-rpc out as well as rust-miniscript before you guys can start using 0.32.0

Great, I'll do it then.

Thanks, I'll follow the discussions on the PRs (https://github.com/rust-bitcoin/rust-bitcoincore-rpc/pull/345 https://github.com/rust-bitcoin/rust-miniscript/pull/679)and repositories closely then.

oleonardolima avatar May 07 '24 01:05 oleonardolima

Hey @oleonardolima you should be good to go after this one goes in: https://github.com/rust-bitcoin/rust-miniscript/pull/688

tcharding avatar May 17 '24 23:05 tcharding

replaced by #1448

notmandatory avatar Jun 13 '24 04:06 notmandatory