bdk
bdk copied to clipboard
chore: add `print_stdout`/`print_stderr` lints to workspace level
potentially fixes #1362
Description
It adds both print_stdout
and print_stderr
deny level lints on workspace level, but it does allow it on test fns through clippy.toml
settings, and explicitly allow it on example code.
Notes to the reviewers
It currently has the setting allowing it on test fns, but open for discussion below.
Changelog notice
- Add both
print_stdout
andprint_stderr
deny level lints on workspace level
Checklists
All Submissions:
- [x] I've signed all my commits
- [x] I followed the contribution guidelines
- [x] I ran
cargo fmt
andcargo clippy
before committing
New Features:
- [x] I've added tests for the new feature
- [x] I've added docs for the new feature
This looks like the right way to prevent prints from getting into the code. But do we even want to allow them on tests? The only place I think they should be allowed is in the examples.
This looks like the right way to prevent prints from getting into the code. But do we even want to allow them on tests? The only place I think they should be allowed is in the examples.
I'm fine with it either way, but I don't see a problem with allowing it for tests.