bdk icon indicating copy to clipboard operation
bdk copied to clipboard

chore: add `print_stdout`/`print_stderr` lints to workspace level

Open oleonardolima opened this issue 9 months ago • 2 comments

potentially fixes #1362

Description

It adds both print_stdout and print_stderr deny level lints on workspace level, but it does allow it on test fns through clippy.toml settings, and explicitly allow it on example code.

Notes to the reviewers

It currently has the setting allowing it on test fns, but open for discussion below.

Changelog notice

  • Add both print_stdout and print_stderr deny level lints on workspace level

Checklists

All Submissions:

  • [x] I've signed all my commits
  • [x] I followed the contribution guidelines
  • [x] I ran cargo fmt and cargo clippy before committing

New Features:

  • [x] I've added tests for the new feature
  • [x] I've added docs for the new feature

oleonardolima avatar May 05 '24 15:05 oleonardolima

This looks like the right way to prevent prints from getting into the code. But do we even want to allow them on tests? The only place I think they should be allowed is in the examples.

notmandatory avatar May 05 '24 21:05 notmandatory

This looks like the right way to prevent prints from getting into the code. But do we even want to allow them on tests? The only place I think they should be allowed is in the examples.

I'm fine with it either way, but I don't see a problem with allowing it for tests.

oleonardolima avatar May 06 '24 13:05 oleonardolima