Steve Myers comments

Results 580 comments of


                                            Steve Myers

Remove `rand` dependency from `bdk`

Thanks for pulling in my commit @rustaceanrob, this now fixes #1479 too.

Feature Proposal: BIP322 message signing

Thanks for the detailed use case info, it sounds like a useful feature to add.

Feature Proposal: BIP322 message signing

This `bdk-reserves` module for `bdk-cli` implements functionality inspired by bip-322, it could be a good starting point for working on more general message signing for BDK. https://github.com/bitcoindevkit/bdk-reserves

Feature Proposal: BIP322 message signing

@moneyball, thanks for the background. Based on the arguments in above links I don't support adding this as a feature to BDK.

`Wallet::create_signers` should return the `KeychainTxOutIndex` changeset

I don't this this issue is valid anymore.

Substitute `enable_rbf` in `TxBuilder` with `disable_rbf`

Concept ACK, seems to be direction bitcoin core is going with bitcoin/bitcoin#25353. Even with all the controversy I think best practice from a general wallet point of view is to...

Substitute `enable_rbf` in `TxBuilder` with `disable_rbf`

Since this is a breaking change we're going to hold off on this until 1.0 since that is a more obviously breaking release.

Substitute `enable_rbf` in `TxBuilder` with `disable_rbf`

A small change but I think we should push to 2.0 milestone.

Substitute `enable_rbf` in `TxBuilder` with `disable_rbf`

@FlamingSaint hi sure go ahead and create a PR, there might also be some additional related changes, see discord discussion here: https://discord.com/channels/753336465005608961/753367451319926827/1228063458952478792

Substitute `enable_rbf` in `TxBuilder` with `disable_rbf`

@FlamingSaint per your question on discord, yes you should use the same PR to make RBF the default for TxBuilder. So yes add `disable_rbf()` but since we still need a...