Steve Myers comments

Results 580 comments of


                                            Steve Myers

(maintenance) doc(bdk): Clarify the absolute_fee docs

This one should just need a rebased after #1366 and then is ready to merge.

Wallet::get_descriptor_for_keychain should return an Option

A small change but I think we should push to 2.0 milestone.

build(deps): bump Swatinem/rust-cache from 2.2.1 to 2.7.3

@dependabot rebase

build(deps): bump Swatinem/rust-cache from 2.2.1 to 2.7.3

@dependabot rebase

Migrate to bitcoin::FeeRate

> * A sanity check that a given rate when applied to a minimum valid tx size doesn't produce an amount greater than `MAX_MONEY` The fee and fee rate sanity...

Migrate to bitcoin::FeeRate

This one needs a rebase after alpha.5 release.

Calling `example_electrum sync` on an unconfirmed tx may result in the tx being stuck as unconfirmed eternally (according to the cli))

Move to beta milestone to re-test.

BIP 326 Anti Fee Sniping

Since this is a functional change I moved it to the alpha.4 release. If we don't think we'll be able to implement it right now I'll move it to the...

BIP 326 Anti Fee Sniping

I propose we push to to a post 1.0 release since it's a functional improvement that shouldn't change the current wallet API.

Reintroduce descriptor data to `bdk::Wallet` persistence

Had a little discussion about this with @evanlinjin and rather than persist the full descriptors I like the idea of offering a different trait for storing the descriptors, in case...