bdk-cli icon indicating copy to clipboard operation
bdk-cli copied to clipboard

add validate domain option to electrum

Open dspicher opened this issue 2 years ago • 2 comments

Description

Added the validate_domain option to Electrum arguments.

Since https://github.com/bitcoindevkit/bdk-cli/pull/151 seems dormant, I took another stab at this.

Fixes https://github.com/bitcoindevkit/bdk-cli/issues/134.

Changelog notice

Added the validate_domain option to Electrum arguments.

Checklists

All Submissions:

  • [x] I've signed all my commits
  • [x] I followed the contribution guidelines
  • [x] I ran cargo fmt and cargo clippy before committing

New Features:

  • [x] I've added tests for the new feature
  • [x] I've added docs for the new feature
  • [x] I've updated CHANGELOG.md

dspicher avatar Jun 09 '23 08:06 dspicher

Take a look at the utils.rs file and on line 403 you need to use this new param you're adding.

notmandatory avatar Jun 16 '23 01:06 notmandatory

Take a look at the utils.rs file and on line 403 you need to use this new param you're adding.

Ah yeah, makes sense. Fixed.

dspicher avatar Jun 16 '23 11:06 dspicher