Nathan Moinvaziri
Nathan Moinvaziri
Well if the project names are different between zlib and zlib-ng in CMake it means that it is no longer a drop in replacement for zlib at least for my...
Even if you were to do `add_subdirectory` between two CMake projects that have different libraries you still have to use `target_link_libraries` to specify the names of the libraries, and if...
I am talking about the project being a CMake drop-in replacement for use with FetchContent or ExternalProject.
Right now in minizip I can use `FetchContent` between zlib CMake and zlib-ng CMake and only add `ZLIB_COMPAT=ON`. Changing project names will break this unless we keep it the same...
Yes of course.
I'm not sure if it is needed but I don't mind either.
Yes, that change would be a good idea to add to the wiki.
Colors work properly in PowerShell command prompt, however it does not work in cmd prompt.
I implemented a retry for requests here and retry number is configurable via args: https://github.com/nmoinvaz/codecov-python/commit/9632dc655ed378ece67bf54861a300dd1e732aef https://github.com/nmoinvaz/codecov-python/commit/30ff5e3140291b1a11bea9f2973efae72d8dd2aa If this is something that would be accepted I can submit a PR.
> codecov-bash tries 3 times already, sleeping for 30s inbetween. Looking at codecov bash uploader it appears to now try 5 times, sleeping for 2s in between.