Nathan Moinvaziri

Results 433 comments of Nathan Moinvaziri

I think there are probably some other GitHub Workflow actions in the marketplace we can use instead.

I tried making a commit mentioned above that used a GHA to detect trailing whitespace, however it doesn't allow you to exclude certain files or directories which it appears we...

This is now resolved in develop branch.

This issue should now be resolved in develop branch.

It looks like this PR causes build failures in MSVC ARM (32-bit): https://github.com/zlib-ng/zlib-ng/runs/8185666610?check_suite_focus=true

We could potentially use detect-arch.c for configure script too.

Some of the logic from `detect-arch.cmake` could be put into `detect-arch.c`. It could print out both the arch and the base arch.

> When cross-compiling, CMAKE_SYSTEM_PROCESSOR must be manually defined. We don't do any cross-compiling scenarios without a toolchain file that defines `CMAKE_SYSTEM_PROCESSOR`. And even in the cross-compiling scenario, we don't actually...

Yeah that seems to be the purpose of the `detect-arch.cmake` script - to normalize the values into `ARCH` and `BASEARCH`. It currently uses `CMAKE_SYSTEM_PROCESSOR` as a fallback. `CMAKE_SYSTEM_PROCESSOR` is essentially...

Have you tried the latest develop branch code?