Nathan Moinvaziri
Nathan Moinvaziri
Actually, I fixed some bugs and I am not seeing any performance benefit on a bitmap image.
## RUN 1 ### DEVELOP ``` Tool: ../zlib-ng/build-develop/Release/minigzip.exe Levels: 0-0 Runs: 70 Trim worst: 40 Level Comp Comptime min/avg/max/stddev Decomptime min/avg/max/stddev Compressed size 0 100.008% 0.221/0.244/0.255/0.010 0.222/0.256/0.269/0.010 211,973,953 R 60.465%...
``` 2022-03-17T19:14:09-07:00 Running C:\Users\nathan\Source\zlib-ng\build-rle\test\benchmarks\Release\benchmark_zlib.exe Run on (8 X 2995 MHz CPU s) CPU Caches: L1 Data 48 KiB (x4) L1 Instruction 32 KiB (x4) L2 Unified 1280 KiB (x4) L3...
After 1 year as a draft this is now ready for review. 🤣
### DEVELOP https://github.com/zlib-ng/zlib-ng/commit/85f9709137a88c546e5dd188f7cb196b80f84253 ``` OS: Windows 10 10.0.22000 AMD64 CPU: Intel64 Family 6 Model 158 Stepping 10, GenuineIntel Tool: ../zlib-ng/build-1/Release/minigzip.exe Levels: 0-0 Runs: 70 Trim worst: 40 Level Comp Comptime...
I'm not so sure this is a real issue. `match_len` can't be larger than `STD_MAX_MATCH`. Coverity may be making some wrong assumptions: ``` match_len = STD_MAX_MATCH - (unsigned int)(strend -...
> I think most/all of them accept assert checks as ground truth, so that might be a possibility (and could also provide sometimes useful checkpoints against things becoming completely out...
@Dead2 I'm surprised that `|| defined(__COVERITY__)` did not work for defining `check_match`. This might do better, to define `check_match` as assert statements when coverity is detected. ```c #ifdef ZLIB_DEBUG ......