Nathan Moinvaziri
Nathan Moinvaziri
Rebased.
I have put together a GHA workflow that reproduces the issue: https://github.com/nmoinvaz/zlib-ng/blob/improvements/dual-link-test/.github/workflows/link.yml CI run: https://github.com/nmoinvaz/zlib-ng/runs/6953216938?check_suite_focus=true Output: ```c [100%] Linking CXX executable gtest_zlib /usr/bin/ld: ../libz-ng.a(crc32_braid.c.o): in function `crc32_braid': crc32_braid.c:(.text+0x60): multiple definition...
What is strange to me is that it has a problem with `crc32_braid` but it does not have a problem with `compare256_c`. Both functions are defined very much the same......
When I use CMake to compile dynamic libraries, all I do is add the .rc to the source files list and CMake does the rest.
@phprus the `__attribute__((__may_alias__))` would be a good idea for a separate PR, I can see it definitely helps on old GCC.
There are some differences in configure and cmake build scripts. In CMake, we do detection based on architecture to see if unaligned access is supported. If it is not supported...
If you want to wait for a declaration of priorities before you contribute then it is up to you, but I would be interested in seeing your proposals as PRs....
Where is that GHA? I can't seem to find it.
Can you add it as a separate workflow .YAML file? Similar to the static analysis one we have.. I don't think we need the precommit hook as everything goes through...