Nathan Moinvaziri

Results 433 comments of Nathan Moinvaziri

Any word on whether or not the latest develop branch works?

@danyspin97 were you able to try it?

[Use PREFIX() for some of the Z_INTERNAL symbols](https://github.com/zlib-ng/zlib-ng/pull/1253/commits/a75f5b3e3deabc8c05d0022f49ced3913ef90c6d) should be its own PR imo. It's been mentioned in issue #1279 also.

[These are the benchmarks](https://github.com/zlib-ng/zlib-ng/discussions/871) which we have done. We don't use LD_PRELOAD when benchmarking. There is also a [deflatebench](https://github.com/zlib-ng/deflatebench) repository which we use specifically for benchmarking. Have you tried building...

Do we want to still keep this issue open?

I've thought about doing this too for google test. I wonder how it should be done. Because minigzip, minideflate, fuzzer_minigzip all share very similar code..

Currently CMake enumerates all files in test/data and runs a test on each file for each compression level/strategy. So I'm not sure if it makes sense to also do that...

That makes sense especially considering that the user will likely want to manually specify a file that can fit in memory, where as google tests doesn't necessary need to worry...

If we were to change the zlib-ng's CMake generated project names they would no longer have the same project names as what is generated by zlib's CMake. Not sure if...