Nathan Moinvaziri comments

Results 433 comments of


                                            Nathan Moinvaziri

Added GitHub Actions workflows

Also we don't check building of any contribs.

minizip has two risks

I don't maintain minizip in this distribution, that would be @madler and @gvollant.

cmake error about “Failed to run MSBuild command”

Remove the CMakeCache.txt file and CMakeFiles directory.

cmake: respect custom RC flags with mingw + delete GCC_WINDRES

Hey @vszakats, sorry I don't have access. I'm just a pleb like everybody else here. 😂

AArch64: use ACLE intrinsics, unroll first and last < 8 bytes of crc32

I have google tests and benchmark in zlib-ng you could use to test this with to see if it really performs better.

zlibstatic - purpose, make optional?

You can use `add_subdirectory(zlib EXCLUDE_FROM_ALL)` and it won't build all the projects.

Add continuous integration (CI)

In zlib-ng we use GitHub Actions. You might want to take a look at that. https://github.com/zlib-ng/zlib-ng/tree/develop/.github/workflows

Add continuous integration (CI)

I noticed there is Cirrus CI, Drone CI, Travis CI, and AppVeyor. Are you adding all the CI platforms? Would you be open to GItHub Actions as well or is...

Add continuous integration (CI)

Some of the toolchain files that I've used before can be found [here](https://github.com/zlib-ng/zlib-ng/tree/develop/cmake). It might come in [hand](https://github.com/zlib-ng/zlib-ng/blob/develop/.github/workflows/cmake.yml).

Minizip Version mismatch in Zlib 1.2.12

AFAIK minizip has its own version number and it is not related to zlib version.