Nikita Popov

Results 517 comments of Nikita Popov

> The side-effecting `\IteratorAggregate` implementations turn out to be defined in my own codebases. It appears that once upon a time I wrote some convenience classes which look almost exactly...

Generally sounds like a reasonable addition, but I'm not sure what a good name would be. We already have a `search()` function which returns the *value* matching a predicate. `searchKey()`...

Looks like the same as https://github.com/llvm/llvm-project/issues/80637. As I noted there, this technically loses information, but I guess in practice it's a lot better to replace with `mul nuw` here. I...

> Even aside from the pattern overall being visible in Rust code beyond hashbrown, most of the code in hashbrown is transitively included in every single Rust program that uses...

I don't think it makes sense to put attributes in a "block". They should be in a property on the class, just like in the AST.

This is the IR generated by rustc: ``` define void @_ZN7example5ctpop17h99089f7f1b127411E(* noalias nocapture sret dereferenceable(16), * noalias nocapture dereferenceable(16) %x) unnamed_addr #0 { %arg = alloca , align 16 %1...

> I'm wondering whether it's possible that after one of the php process acquired the lock, and then it was killed by OOM, the lock held by it could not...

> Fix this lib to convert the square brackets or fix the yacc file in the example dir? Fix the yacc file.

Right now the square brackets only add a new and an attributes argument (https://github.com/nikic/PHP-Parser/blob/master/grammar/rebuildParsers.php#L103), though this used to be a larger transformation previously. In any case, for the purpose of...

This package is compiling the PHP AST into a [static single assignment](https://en.wikipedia.org/wiki/Static_single_assignment_form) form intermediate representation. The SSA construction is implemented using the algorithm described in "Simple and Efficient Construction of...