Nikita Popov

Results 517 comments of Nikita Popov

Implementing Countable sounds good to me.

So until a couple weeks ago this extension was dead. It was originally written for https://www.phpinternalsbook.com/ and only supported PHP 5. Recently @DrDub ported it to PHP 7. So this...

FYI I've added support for PHP 8 now.

Okay, sounds like nobody needs PHP 7 support, so let's drop it.

PHP 7 support is dropped, and we no longer have `#ifdef`s. > If I'm not mistaking, the extension is currently lacking the equivalent of a [DataView](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/DataView). Is this in scope?...

I believe the problematic change here is actually https://github.com/krakjoe/apcu/commit/eb28fe1ab0918e604bd22c6c1c58bae5280b7d72, which switches to using a monotonic clock, which uses a different starting point than `time()`. I think this change needs to...

Change reverted in https://github.com/krakjoe/apcu/commit/8c05c515b698d5f95555a6afdc00846405d50b40. @remicollet Would you mind creating another release for this?

Doesn't looks that this error condition is tested currently, add one?

Looks like apc_099.phpt is failing.