Nikita Popov
Nikita Popov
This issue has been fixed upstream.
@gnzlbg Nope. The relevant monorepo commit is https://github.com/llvm/llvm-project/commit/aa7cfa75f97ed2b7f27b22f626353bc29d03819b#diff-4cd9888950373f65c4898b144777d044. Right now we're still on the LLVM 8 branch (unsure if that means that we will no longer track LLVM trunk?)
@SparrowLii Yes, the relevant LLVM upgrade has happened a long time ago by now :)
@philip There are people using that?
@hakre IDE detects errors quite well without it too ^^ In any case, I feel like mentioning `php -l` isn't really necessary in a beginner tutorial :)
Fixed upstream, https://github.com/llvm/llvm-project/commit/a3be17ea1cf0414ffd9744491ba22a6dd6157369 in monorepo.
This is an LLVM bug: Missing autoupgrade for the intrinsic renames. For reference, the buggy patch was https://reviews.llvm.org/D138249.
Upstream fix: https://reviews.llvm.org/D146424
Sounds reasonable to me!
I don't think it's possible to do anything against this, apart from rejecting `IteratorAggregate` in `isEmpty` entirely, which doesn't seem desirable. I'd consider a side-effecting IteratorAgggregate implementation to be a...