Nikita Popov
Nikita Popov
> Why do you need to directly constant fold the libcalls? We have intrinsics for these, which we arguably should just always replace libcalls with This is a great question....
Can you please add a test that shows the generated IR? It's hard to comment in abstract.
It looks like the store in `5:` still uses `%0`, without a phi. We only have the phi in `common.ret`, where the value is not actually used...
I'm not sure I fully understand what you mean here. Is this about renaming uses so that the inserted phis get used? The phis do need to be integrated with...
By the way, an alternative testing method of which callbacks are invoked by which pipeline can be seen in llvm/test/Other/new-pm-O0-ep-callbacks.ll. That does not rely on plugins at all.
> > I think tests that the plugin mechanism is working makes sense for all tools. > > I agree, but I also agree with nikic that it should only...
It looks like you end up mixing version 4.x and 5.x of PHP-Parser somehow. You have 4.x in your project and phpunit comes with it's own version -- how did...