Nikita Popov comments

Results 517 comments of


                                            Nikita Popov

Update to LLVM 18

The discussion on that PR suggests that we should drop passing `--fatal-warnings` -- that seems fine, given that we only do this for wasm in the first place.

Update to LLVM 18

Testing Windows in try. @bors try

Update to LLVM 18

Meh, looks like these run tidy, so we'll have to wait on compiler-builtins first.

Update to LLVM 18

@bors try

Stop using LLVM struct types for byval/sret

@bors r+ rollup=never

Stop using LLVM struct types for byval/sret

@bors r+

Stop using LLVM struct types for array/pointer offset GEPs

I'm not sure this is a particularly useful change to make at this time.

Copy byval argument to alloca if alignment is insufficient

Need to adjust the comment added in https://github.com/rust-lang/rust/pull/122050.

Fix 32-bit overflows in LLVM composite constants

Would you be interested in upstreaming the new APIs to LLVM? If you do that, then we can directly start using them by providing shims like this: ``` // Or...

Fix 32-bit overflows in LLVM composite constants

@bors r+