support of php attributes

[eric-therond]

I would like to improve php-cfg to add information about php attributes in the CFG.

For this code sample:

#[ExampleAttribute('Hello world', 42)]
class NameOfClass {
}

Do you think the following output to generate is correct?

Block#1
    Stmt_Class
        name: LITERAL('NameOfClass')
        stmts: Block#2
        attrs_group: Block#3

Block#2

Block#3
    AttributeGroup
        attrs[0]: Block#4

Block#4
    Attribute
        name: LITERAL('ExampleAttribute')
        args[0]: LITERAL('Hello world')
        args[1]: LITERAL(42)

Eric

[nikic]

I don't think it makes sense to put attributes in a "block". They should be in a property on the class, just like in the AST.

[eric-therond]

So more something like that:

Block#1
    Stmt_Class
        name: LITERAL('NameOfClass')
        stmts: Block#2
        attrs_group[0]: ExampleAttribute('Hello world', 42)