Nicolas Grekas

icon company @SymfonyCorp icon location Paris, France icon location Submitting features and bug(fixes) @symfony, to make it always faster, easier to use and better designed, uncompromising. @ESPCI_Alumni engineer.

Results 634 comments of Nicolas Grekas

[symfony/framework-bundle/7.2] Start with an empty APP_SECRET

Check https://github.com/symfony/symfony/pull/56985, it should answer that. Let me know if not completly.

[symfony/framework-bundle/7.2] Start with an empty APP_SECRET

PR ready for merge @symfony/mergers

[Serializer] Support enums that implement `JsonSerializable` in `BackedEnumNormalizer`

Looks like we can close this PR, isn't it?

[HttpClient] Fix that staged exceptions were not thrown when calling `MockResponse::getStatusCode()`

Did you try setting the "error" info when constructing the MockResponse instead?

[HttpClient] Fix that staged exceptions were not thrown when calling `MockResponse::getStatusCode()`

Those are mocking two different moments where exceptions can be thrown: before headers vs after them;

[HttpClient] Fix that staged exceptions were not thrown when calling `MockResponse::getStatusCode()`

Doc PR welcome!

`PasswordStrengthValidator` logic always return `Weak` even for strong password

`#Q_81($r7` is indeed a weak password: it's way too short, thus can be cracked quite quickly

[AssetMapper][FrameworkBundle] Do not require `http_client` service

Ah: why do you consider this as a bugfix? To me it's for 7.2

[DependencyInjection] Multiple `Autoconfigure` attributes are accepted, but the default values of the last one are applied

Is that new to 7.1?

[DependencyInjection] Multiple `Autoconfigure` attributes are accepted, but the default values of the last one are applied

Thanks for digging. I think we can consider this behavior as a bug. Up for a PR?