Nicolas Grekas

Results 733 comments of Nicolas Grekas
trafficstars

> implement the ResetInterface to prevent memory leaks? If all we store is class metadata, we don't need a reset IMHO as the leak is upper bounded, and resetting might...

This should use registerForAutoconfiguration instead, the current code defines a local-only rule, but I suppose you want to exclude constraints defined by apps, isn't it?

> Currently we indeed use a hack involving a context in passed by reference Wouldn't using a state object in the context work instead?

What's the next step here? How do we make it easy to opt-in for the OWASP-recommended normalization?

Can you give us a hint about how this can be used? : )

wait, no, it needs a review! "needs-review-translation"

Hi thanks for the PR. I'm surprised this change is in VarDumper and not in VarExporter. Does this really fix the issue you have? Can you please share a small...

Same as a few others here: I'm only interested in talking about code. At the moment, I don't get the problem this is trying to solve for the community so...