Nicolas Grekas

Results 634 comments of Nicolas Grekas

@illodev could you please put all this in a repo on github that'd allow reproducing easily?

Could this be fixed by https://github.com/doctrine/orm/pull/11544? Could anyone give it a try?

I tried relying on __call but that breaks the CI so I reverted to listing methods explicitly. About shopware/etc. I suppose they do the same mistake. Possibly a `RefreshGlobalsInterface` could...

> this will still break if templates do things like {% if ea is defined %} True, and there is no way around this so we have to go with...

Both should be merged, and a deprecation should be added here. Note that the getGlobals() method should be deprecated soon in twig.

The issue is using globals for request-local state. See https://github.com/EasyCorp/EasyAdminBundle/pull/6273 for a discussion about this, and a possible solution, which might not belong to Twig in the end.

Maybe twig should deprecate GlobalsInterface?

Please keep a respectful tone; "look like a clown" isn't very nice if you don't mind. That being said, I'd be fine removing minification from the assetmapper doc since compression...

We have a concept of asset compilers, so maybe we could make it easy to plug one? Did anyone write a bundle for this already? Up to have a look?