Nicolas Grekas

Results 634 comments of Nicolas Grekas

Thanks for all the insights. Seeing 85 there is unexpected to me but that goes beyond Symfony's responsibility. At least here we're done :)

The concept of "static" and "service" look orthogonal to me. Static is a kind of global state while a service is an instance, aka it has a local scope only....

So, you are using a static method as a factory for a closure and you're adding attributes on that factory to configure how it is wired? Works for me. But...

There is only src/Symfony/Component/DependencyInjection/Tests/Compiler/AttributeAutoconfigurationPassTest.php :)

Closing as explained, thanks for proposing.

Thanks for the proposal. On my side, I think this is a lot of code infrastructure, challenges (compile/runtime code generation) and third party dependencies for a use case that is...

Another note: once #47236 is merged, it should be possible to replace proxy-manager by code generation based on reflection + `ProxyHelper::exportSignature()`. I'd be happy to know how this goes if...

Sorry to come late in the review, but can't we use the intl-icu suffix in the domain to decide for the correct format?