Nicolas Grekas

Results 382 comments of Nicolas Grekas

Friendly ping @weaverryan, could you have a second look?

This means opening the session on every single page. I don't think that's a good default for this reason...

I'm sorry but my previous comment will always be true: no matter how you write it, there is no way to have both flash messages and http caching when the...

Another opinion on this one: let's say we merge this. It'd mean we'd make it harder to use http caching since ppl would first need to figure out the issue...

You're right, disabling the session is just 🙈 :) This concern happens on a page by page basis, so we could look for a way to display/ignore flashes page by...

I thought about it and I'm :-1: Instead, I think we should promote flash messages based on turbo-frames.

(please rebase so that we can run the new checks)

This should target the recipe for 5.3 IMHO.

At least, since we don't use symlinks anymore, this should update the latest of each major.