Nico Weber

Oh wait, I had a local diff applied that makes this a bit better. On trunk, the "reencode 100 times" experiment leads to a final color of (98, 150, 90),...

https://github.com/SerenityOS/serenity/compare/master...nico:serenity:jpeg-colors-reloaded?expand=1 gets it from ``` % Build/lagom/bin/test-jpeg-roundtrip color #ff0000ff converges to #b86a5aff after saving 52 times, delta 16.20746 color #00ff00ff converges to #62965aff after saving 51 times, delta 28.695068 color...

Some notes on rsqrt(8) precision: A completely black 8x8 tile has -1024 in the Y DC component (in (0, 0), and zeros everywhere else. The fast idct code computes -1024...

Re "is the decoder 'correct enough'"? See commit 3 here: https://github.com/SerenityOS/serenity/compare/master...nico:serenity:jpeg-decoder-compliance?expand=1 The answer is: It currently isn't. To get it correct enough needs less than the changes in https://github.com/SerenityOS/serenity/issues/22739#issuecomment-1912899925 – ...

What's the advantage of String and ByteString having the same memory layout?

Is the paused state very visible with a clear indicator how to I pause?

Very cool! But while 55s is much better than not finishing at all, it's still pretty slow. MacPDF loads it in under 1s (likely in faster hw, but likely not...

> The first thing PDFViewerWidget::open_file() does is to read the entire file into memory. This takes 15-20 seconds on my machine. I'm don't know how necessary it is to read...

It's fast on most pages on most PDFs, so it's probably more interesting than "this is always slow". Also, I think a PDF does "create path, set as clip, draw...

:thonk: Yeah, you're right!