Nico Weber

Results 269 comments of Nico Weber

> Google hands out $10K+ in rewards for V8 security vulnerabilities in nearly every major release of Chrome, most of which can be traced to TurboFan (their JIT compiler). So...

Before: After: Before: After: Before: After: Before: After:

These are the files this helps with: ``` Malformed PDF file: Unhandled command, in 5 files, on 38 pages, 337 times /Users/thakis/Downloads/0000/0000521.pdf 1 (3x) 2 (18x) 3 4 (2x) 5...

I'm here because the release notes asked for feedback. Maybe it makes sense to have one comment per bullet point, so that people can thumbs-up and thums-down each item? *...

If you use https://llvm.org/PR48886 it should redirect to the matching GitHub issue.

In my case, I had something that _didn't_ compile, but with this, it did. But now that I've looked a bit more at my thing, I'm not sure the default...

Completely agreed! But MaybeOwned's thing is that is's either a NNOP or a reference, so moving half of it is unsound. So maybe the type shouldn't be movable either? Or...

A NNOP will point to something on the heap. If you move something around, the address of the heap thing won't change. A reference can ref something on the stack,...

The concrete suggestion from https://github.com/SerenityOS/serenity/pull/19031#issuecomment-1562901677 in some more detail: ``` MaybeOwned(MaybeOwned&& rhs) : m_handle(move(rhs.m_handle)) { // A moved reference still points at the old location for refs to stack variables....

Are there images like this in the wild? libjpeg-turbo seems to not be able to decode this.