Nico Weber
Nico Weber
Maybe good to return an enum class instead of a bool so that this impossible to get wrong?
(Red CI is real though.)
> Fly-by opinion - I'd rather default to removing old versions when a new version is picked up. Can you say more on why? The files in my Build/caches are...
We could delete the files when they're N weeks old or something. Don't focus on the 'on a train' part too much – just bisecting across these is annoying, no?
Before: After: Before: After: Before: After: Before: After:
Can you put the first two commits in a separate PR from the last two? The last two are great / embarrassing and should go in as fast as possible...
On the approach: A file I like (or dislike) for testing CLUT perf is 0000711.pdf. It has many full-page CMYK images, which are currently unusably slow to convert (takes 3s...
#23253 makes things twice as fast in many cases, and speeds up 0000364.pdf enough that it's just barely the long pole. So I feel even more that this patch here...
IPv6 support is not implemented yet.
Before: After: Before: After: Before: After: