Nico Weber
Nico Weber
This is looking great, but has pending comments. Also, adding something to Tests/LibGfx/TestImageWriter.cpp, similar to test_webp_animation in there, would be good. Marking as "waiting for author" in the meantime :)
I turned this into #24927. Thanks for the great starting point!
Sure. Do you want a tag called "v1.0" that tags current main, then v1.1 that tags some future version, or a tag called "version" that's updated every now and then?...
Happy to accept a patch for this.
Sure, patches accepted.
> I think it is unlikely that FDs from this pipe are leaked. It's possible this theory is wrong. Background is that n2 needs way more FDs than ninja (`ninja...
#25 fixes this locally for me, so it does look like that race creation race is indeed the cause of the fd leak. WIth that patch applied, and the build.ninja...
(I also filed an upstream issue.)
I think 9c2104a3ca3b6225b126ac193213c2642e1a7147 regressed this. The test in https://github.com/evmar/n2/issues/14#issuecomment-1084646807 repros this again. (I don't have permissions to reopen this issue here.)
Evan: Think of this as not competing with the platonic ideal of a perfect build, but with the current reality of cmake builds shelling out to cmake and ninja in...