serenity
serenity copied to clipboard
LibWeb: Invert return value from EventHandler key event handling methods
EventHandler::handle_keyup()
and EventHandler::handle_keydown()
return true if the event has been handled and false otherwise. This is the opposite behavior to EventHandler::fire_keyboard_event()
. This change inverts the return value from fire_keyboard_event
in these methods, allowing shortcut keys to be propagated to the Serenity Browser UI as expected.
Fixes #23159
Maybe good to return an enum class instead of a bool so that this impossible to get wrong?
Agree with nico although we can do that as a bigger change :)