Nick Krantz
Nick Krantz
> @nick-livefront @jtouchstonebw mentioned in [chromatic](https://www.chromatic.com/pullrequest?appId=62a88a6de5b807fa98886113&number=8810&activeElementId=comparison-test-key-662a75e65ee9411d85cb55b6-1200px&view=changes) that spacing between icon and text looks a bit smaller than in general. @Hinton @jtouchstonebw I missed some margin on the icons in that...
@shane-melton @gbubemismith @jlf0dev @justindbaur I addressed two defects here: - [AC-2588](https://bitwarden.atlassian.net/browse/AC-2588) -> [6bf83ff](https://github.com/bitwarden/clients/pull/8899/commits/6bf83ff751bc7def08528b1f9e97533ed6f20649) - [AC-2589](https://bitwarden.atlassian.net/browse/AC-2589) -> [1ba0a0c](https://github.com/bitwarden/clients/pull/8899/commits/1ba0a0ce33b702c5c3031c845388602a354c5b3a) [AC-2588]: https://bitwarden.atlassian.net/browse/AC-2588?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ [AC-2589]: https://bitwarden.atlassian.net/browse/AC-2589?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ
@jlf0dev @gbubemismith When you have some time, could you give this one another review?
~~@shane-melton Re-reqeusting your review, I added the policy here for the UI.~~
@shane-melton Just an fyi - your 'clone cipher' screen shot is missing
@shane-melton Mentioned this PR after discussing [PM-9455](https://bitwarden.atlassian.net/browse/PM-9455) with me. After pulling down these changes and reverting [my previous solution](https://github.com/bitwarden/clients/pull/10024), this would indeed solve [PM-9455](https://bitwarden.atlassian.net/browse/PM-9455). I'll create a PR stacked on...
@willmartian @vleague2 When you have time, could you give this one a review?
> 1. I am seeing a double scrollbar in Storybook: I also was not seeing this because of my mac settings 😅 I had to move some styles and elements...
> Could you also update the popup layout mdx documentation for Storybook to document the new slot and its usage? @vleague2 I added a small blurb here. Do you think...
@shane-melton You're a code owner on the vault changes here, when you get a chance can you take a look?