Nick Krantz

Results 43 comments of Nick Krantz

> You indicated we should talk offline, so I was letting this PR sit. Is that no longer necessary? My apologies, no longer the case! I don't have anything to...

> Also, did you notice any performance hit when the feature flag is off compared to the current state on main? @gbubemismith Good question! I'm actually seeing some interesting results...

@gbubemismith While doing some testing for performance I came across some areas that needed fixing. Probably missed while keeping this PR up to date: - [2d89716](https://github.com/bitwarden/clients/pull/15174/commits/2d897160293342d45bec813ee3f8648ee9877946) - `uriChecksum` was coming...

I have some feedback to address from QA, I will raise separate PRs for those. For now I'm moving this to a draft.

@gbubemismith @jrmccannon This is ready for re-review! I had a couple of fixes after your last review: - [1e1ee9b](https://github.com/bitwarden/clients/pull/15174/commits/1e1ee9b09576693ab72eb09a9f4cf52a9e0180b8) - My vault filter was not working on browser, I had...

@shane-melton I had to fix a test from merging in `main`. [0daf3d1](https://github.com/bitwarden/clients/pull/14980/commits/0daf3d1e51241f370ade869a58b91b78bd7e4f3c)

@shane-melton I merged https://github.com/bitwarden/clients/pull/15247 into this branch so all of the changes are together. Just an FYI that it will need another review pass.

@shane-melton Another update after Kyra's round of QA. [1ee8b07](https://github.com/bitwarden/clients/pull/14980/commits/1ee8b07d1326508bb9b0f6ff46d1b5b28c4d6a76), I missed the description which accounts for the number of at risk passwords |Before|After| |-|-| |||

> 🎨 Given that we have a bug that we are squashing (nice work!), what's our team consensus/goal/standards/etc. on writing covering unit test(s) and/or integration tests? @theMickster Great thought, I...

@shane-melton @jaasen-livefront @bitwarden/dept-dbops This failed to pass QA and after a fresh install of the server repo, my fix was not working. When initially building I must have DB made...