clients [PM-7162] Cipher Form

🎟️ Tracking

📔 Objective

Lay the initial ground for the the new add/edit cipher form that makes full use of the CL. Includes the first Item Details section that will be re-used for all cipher types.

Note for reviewers -- I recommend stepping through each commit to more easily understand the changes in more digestible chunks. I tried my best to make them descriptive and build upon each other without introducing too much many changes at once. Also, a significant chunk of the line changes are related to spec files and storybook.

📸 Screenshots

See storybook for interactive demonstrations.

Add New Cipher	Edit Existing Cipher

Partial Edit Cipher	Clone Cipher

⏰ Reminders before review

Contributor guidelines followed
All formatters and local linters executed and passed
Written new unit and / or integration tests where applicable
Protected functional changes with optionality (feature flags)
Used internationalization (i18n) for all UI strings
CI builds passed
Communicated to DevOps any deployment requirements
Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

👍 (:+1:) or similar for great changes
📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
❓ (:question:) for questions
🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
🎨 (:art:) for suggestions / improvements
❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
⛏ (:pick:) for minor or nitpick changes

Jun 20 '24 22:06 shane-melton

Codecov Report

Attention: Patch coverage is 40.62500% with 171 lines in your changes missing coverage. Please review.

Project coverage is 29.60%. Comparing base (9294a4c) to head (2594931).

Files	Patch %	Lines
...rc/cipher-form/components/cipher-form.component.ts	22.22%	39 Missing and 3 partials :warning:
...ponents/vault-v2/add-edit/add-edit-v2.component.ts	0.00%	40 Missing :warning:
libs/vault/src/cipher-form/cipher-form.stories.ts	0.00%	22 Missing :warning:
...ipher-form/services/default-cipher-form.service.ts	12.50%	21 Missing :warning:
...orm/services/default-cipher-form-config.service.ts	37.50%	15 Missing :warning:
...vault/popup/components/vault/vault-v2.component.ts	0.00%	11 Missing :warning:
...nts/item-details/item-details-section.component.ts	88.50%	3 Missing and 7 partials :warning:
...ew-item-dropdown/new-item-dropdown-v2.component.ts	0.00%	9 Missing :warning:
libs/components/src/select/select.component.ts	0.00%	1 Missing :warning:

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #9758      +/-   ##
==========================================
+ Coverage   29.55%   29.60%   +0.05%     
==========================================
  Files        2538     2548      +10     
  Lines       74221    74490     +269     
  Branches    13874    13932      +58     
==========================================
+ Hits        21935    22056     +121     
- Misses      50637    50775     +138     
- Partials     1649     1659      +10

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.