Nick Krantz

Results 43 comments of Nick Krantz

@justindbaur @ike-kottlowski When you have some time, would you be able to review this PR?

~~Converting to draft, I realized I missed some acceptance criteria. I need to add some reference events.~~ Edit: reference events are being omitted from the AC

> Even though this component is rendered by the sidebar, it actually contains a `bit-banner` which is positioned at the top of the page. @eliykat Thank you for validating and...

> Sorry for the delay. I've discussed the UX with design and we decided to remove the `Switch` text completely. This should resolve the concerns about it not being clickable....

@Hinton @eliykat @LRNcardozoWDF @Thomas-Avery I had 3 defects come back, I added each as a commit here. Let me know if an alternate process is preferred! [PM-7899](https://bitwarden.atlassian.net/browse/PM-7899) - [c78490b](https://github.com/bitwarden/clients/pull/8810/commits/c78490b665ee676c3240872edaf054986e4c42da) [PM-7951](https://bitwarden.atlassian.net/browse/PM-7951)...

@Hinton @eliykat @LRNcardozoWDF @Thomas-Avery I had another defect come back around but to solve I had to alter a component library component, so I pulled that into a separate PR...

> @nick-livefront one question above about an error message. Also, the "Create account" button doesn't stretch the width of the form in the designs. @micahblut This is configured by the...

My apologies everyone, turns out I had an old version of prettier and needed to update. That caused a bunch of files to be changed. [35bb619](https://github.com/bitwarden/clients/pull/9091/commits/35bb6194eba30af4386acc167eb6d7cba6b1092b)

> I assume you mean #9128? :) Yes I do! Thank you 🙇

@Hinton @eliykat @LRNcardozoWDF @Thomas-Avery https://github.com/bitwarden/clients/pull/9128 merged into this branch! Ready for review, I appreciate the patience 🙌