Nick Krantz
Nick Krantz
@shane-melton Jason previously approved this one but it got dismissed when I updated some stuff from Vicki's review. When you have a chance could you give this one a review?
> ❓ Are you still able to modify the cipher after uploading an attachment? I'm worried that we don't return the updated cipher in the attachment endpoint so the `cipher.revisionDate`...
Marking this a draft as I have yet to track down all of the necessary changes on server and client side. Priorities have changed so I'll be taking up some...
@shane-melton I order to support this change for deleting an attachment, the UI needed to know the updated revision timestamp. I added logic to return the updated cipher to both...
Moving to a draft as this work is being tabled for a couple weeks why we wait for the extension refresh to roll out.
> This looks good to go! I'd suggest holding off merging until @gbubemismith's parent PR is merged as its currently undergoing QA. (unless you feel differently @gbubemismith) I'll wait to...
@Jingo88 @shane-melton Rebased on top of `main` after @gbubemismith's merge
> 🤔 Why not make the span on line 10 compatible? Seems like you should be able to embed the `tw-sr-only` content immediately after the icon button. I'm not following...
> The icon would be invisible to the screen reader, wouldn't it? Yes it does but it creates inconsistencies between screen readers, QA pointed out that NVDA is reading each...
@audreyality Bringing this one back around as it has been open for awhile. When you have some time could you give this another look?