PM-21024 ChangePasswordUri controller + service
đī¸ Tracking
PM-21024 Client PR: https://github.com/bitwarden/clients/pull/14912
đ Objective
Retrieving a password change url for a website is not possible on the web because the requests are blocked by the CSP policy. This moves the same logic from the client to the server.
- Contained within the existing
IconsServiceas they have similar use cases - logic performed on decrypted cipher data. - Follows the same patterns for caching/logging as the
IconsController - Checks for an invalid response and a valid response from
/.well-known/change-password - Added new Policy so organizations can enable/disable usage of this endpoint.
- â I added a separate settings for caching so the values can be distinguished between icon controller. Not necessary if these values rarely change.
đ¸ Screenshots
đĻŽ Reviewer guidelines
- đ (
:+1:) or similar for great changes - đ (
:memo:) or âšī¸ (:information_source:) for notes or general info - â (
:question:) for questions - đ¤ (
:thinking:) or đ (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion - đ¨ (
:art:) for suggestions / improvements - â (
:x:) or â ī¸ (:warning:) for more significant problems or concerns needing attention - đą (
:seedling:) or âģī¸ (:recycle:) for future improvements or indications of technical debt - â (
:pick:) for minor or nitpick changes
Checkmarx One â Scan Summary & Details â 5b9039fb-56e2-40fd-a9cc-0c738b9eac1c
Great job! No new security vulnerabilities introduced in this pull request
Codecov Report
:x: Patch coverage is 32.55814% with 87 lines in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 48.48%. Comparing base (db4beb4) to head (b289b57).
:warning: Report is 75 commits behind head on main.
Additional details and impacted files
@@ Coverage Diff @@
## main #5845 +/- ##
==========================================
- Coverage 48.51% 48.48% -0.03%
==========================================
Files 1740 1744 +4
Lines 77299 77428 +129
Branches 6913 6924 +11
==========================================
+ Hits 37499 37541 +42
- Misses 38283 38370 +87
Partials 1517 1517
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
:rocket: New features to boost your workflow:
- :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
- :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
Quality Gate passed
Issues
2 New issues
0 Accepted issues
Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code
~~@shane-melton Re-reqeusting your review, I added the policy here for the UI.~~
Quality Gate passed
Issues
2 New issues
0 Accepted issues
Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code