clients icon indicating copy to clipboard operation
clients copied to clipboard

[PM-1655] Trial Registration Layout

Open nick-livefront opened this issue 1 year ago • 1 comments

Type of change

- [ ] Bug fix
- [x] New feature development
- [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc)
- [ ] Build/deploy pipeline (DevOps)
- [ ] Other

Objective

Migrate from the TrialInitiationComponent to a new component that utilizes the AnonLayoutWrapperComponent. All existing marketing content will come before this new component and handled via CMS.

** The first step will be replaced by the component created in PM-7318

Open Questions

There is a lot of refactoring that could occur here or follow. I tried to keep this PR smaller and solicit feedback first.

  • The secrets manager components were separate in the old implementation. I opted to combine them to try and DRY things up. After completing the work, the FinishSignUp component feels on the verge of too large. Any instinct if I should pull out the secrets manager logic here?
  • There is a discussion about what query parameters should be accepted in PM-5093. I scoped my changes to only using the new parameters but downstream components should probably be refactored as well?
  • The SubscriptionProduct enum & the new Product enum I added here represent the same thing in different ways. Another refactor opportunity possibly?

Code changes

  • finish-sign-up.component.ts:
    • New sign up component, heavily based off of TrialInitiationComponent
    • Consolidated Secrets manager logic here were applicable.
  • finish-sign-up/enums/product.ts:
    • New enum to match the product query param
  • free-trial-text.resolver.ts:
    • Angular Resolver to resolve the pageTitle passed to the AnonLayoutWrapperComponent
  • confirmation-details.component.html:
    • Allow for both SecretsManager & PasswordManager to use the same confirmation message

Screenshots

Password Manager Password Manager - Enterprise Secrets Manager - Enterprise
Screen Shot 2024-05-08 at 15 44 38 PM Screen Shot 2024-05-08 at 15 44 53 PM Screen Shot 2024-05-08 at 15 45 06 PM

Before you submit

  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team
  • Ensure that all UI additions follow WCAG AA requirements

nick-livefront avatar May 08 '24 20:05 nick-livefront

Logo Checkmarx One – Scan Summary & Details9ea97801-8ec5-4220-91e9-a0386b632034

No New Or Fixed Issues Found

github-actions[bot] avatar May 08 '24 21:05 github-actions[bot]

Codecov Report

Attention: Patch coverage is 16.26506% with 139 lines in your changes missing coverage. Please review.

Project coverage is 31.82%. Comparing base (ea72552) to head (b94d7fa).

Files Patch % Lines
...-initiation/complete-trial-initiation.component.ts 0.00% 127 Missing :warning:
...trial-initiation/confirmation-details.component.ts 0.00% 3 Missing :warning:
...p/auth/trial-initiation/trial-initiation.module.ts 0.00% 2 Missing :warning:
apps/web/src/app/oss-routing.module.ts 0.00% 2 Missing :warning:
...h/src/angular/anon-layout/anon-layout.component.ts 0.00% 2 Missing :warning:
...al-initiation/resolver/free-trial-text.resolver.ts 96.42% 0 Missing and 1 partial :warning:
...gular/anon-layout/anon-layout-wrapper.component.ts 0.00% 1 Missing :warning:
libs/common/src/billing/enums/index.ts 0.00% 1 Missing :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9091      +/-   ##
==========================================
- Coverage   31.86%   31.82%   -0.04%     
==========================================
  Files        2610     2612       +2     
  Lines       78951    79117     +166     
  Branches    14859    14899      +40     
==========================================
+ Hits        25155    25179      +24     
- Misses      51842    51983     +141     
- Partials     1954     1955       +1     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar May 20 '24 14:05 codecov[bot]

@nick-livefront one question above about an error message. Also, the "Create account" button doesn't stretch the width of the form in the designs.

micahblut avatar Jul 11 '24 09:07 micahblut

@nick-livefront one question above about an error message. Also, the "Create account" button doesn't stretch the width of the form in the designs.

@micahblut This is configured by the underlying component. Danielle gave the go-ahead to continue as is and this can be fixed in the component. Figma discussion.

nick-livefront avatar Jul 16 '24 20:07 nick-livefront

My apologies everyone, turns out I had an old version of prettier and needed to update. That caused a bunch of files to be changed.

35bb619

nick-livefront avatar Jul 29 '24 18:07 nick-livefront