Max Inden

Results 899 comments of Max Inden

Wonderful. Thanks @ddeguglielmo for testing. And of course @gallegogt and @thomaseizinger for fixing this issue!

> However there does not seem to be any progress on this, or any updates to quickcheck, for over a year now. Exactly right. That is the reason why rust-libp2p...

> without a dependency to proptest in the original crate and thus without orphan-rule issues. In this case, we control all crates and we would depend on `proptest` anyways, thus...

Thanks @kpp and @thomaseizinger for fixing this.

How about a `continue` statement for the outer loop?

> How about moving [wasm-timer](https://github.com/tomaka/wasm-timer) into the `rust-libp2p/misc` dir I would much rather like to see it replaced with a timing library that is still actively maintained. See https://github.com/libp2p/rust-libp2p/issues/2497#issuecomment-1038923700. Contributions...

Instead of moving another generic library into the rust-libp2p monorepo, I think we can replace the use of quicksink in `libp2p-websocket` instead. Not a strong opinion, though would prefer not...

Hi @JerryHue, > Would it be okay for me to work on this issue Yes for sure. Your help would be very much appreciated. > with some guidance? :+1: I...

_Sorry for the late reply here. I was sick for the last week._ --- > ### Encoding to the string representation > > As per the RFC requirements, the `PeerId`...

:wave: Max here, maintainer of (rust-) libp2p. It is great to see interest in libp2p and great to see the many tracking issues and specifications being useful. Feel free to...